Fix Mypy Linter Errors in plotting.py #405
Closed
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
JasonKChow
requested changes
Oct 15, 2024
|
@JasonKChow has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@JasonKChow has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@JasonKChow has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JasonKChow
approved these changes
Oct 15, 2024
|
@JasonKChow merged this pull request in 8f38b4a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves mypy linter issues in
plotting.pyby addingNonechecks forstrat.model, providing a missing type hint for thelocsvariable, and updatingmatplotlib.markersto use a string digit instead of an integer.This was done because adding more strict type hints in other parts of the code revealed these errors, which need to be fixed before proceeding with #403 .