Adjust object-introspection to llvm-18 API changes #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D61548431 |
JakeHillion
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 60.79% 60.79% -0.01%
==========================================
Files 126 126
Lines 12491 12493 +2
Branches 2014 2014
==========================================
+ Hits 7594 7595 +1
- Misses 3940 3941 +1
Partials 957 957 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61548431 |
MatzeB
added a commit
to MatzeB/object-introspection
that referenced
this pull request
Aug 20, 2024
…tal#506) Summary: Pull Request resolved: facebookexperimental#506 LLVM-18 changed the `CompilerInvocation` APIs to return references instead of pointers... Reviewed By: JakeHillion Differential Revision: D61548431
MatzeB
force-pushed
the
export-D61548431
branch
from
9eaf79b to
afc4104
Compare
…tal#506) Summary: Pull Request resolved: facebookexperimental#506 LLVM-18 changed the `CompilerInvocation` APIs to return references instead of pointers... Reviewed By: JakeHillion Differential Revision: D61548431
|
This pull request was exported from Phabricator. Differential Revision: D61548431 |
MatzeB
force-pushed
the
export-D61548431
branch
from
afc4104 to
8c71972
Compare
|
Not sure why this test job failed. Seems unrelated to the changes. |
How strange, that CI job isn't usually flaky. I restarted it and you're good to land this in Phabricator now. |
facebook-github-bot
merged commit 40d3f39
into
facebookexperimental:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: LLVM-18 changed the
CompilerInvocationAPIs to return references instead of pointers...Differential Revision: D61548431