Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and test LLVM version 16 #504

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JakeHillion
Copy link
Contributor

@JakeHillion JakeHillion commented Aug 15, 2024

Add LLVM-16 to the Nix builds and CI matrix. Also add the option to explicitly
select an LLVM version so the CircleCI build can still work as before.

We should support at least LLVM-17 currently, but there appears to be a
significant performance regression in compiling the generated code for large
variants that I'm going to debug separately. The long term goal is to support
and test all versions 15 and up.

Test plan:

  • CI

@JakeHillion JakeHillion force-pushed the pr504 branch 3 times, most recently from 213afc7 to e8650a4 Compare August 16, 2024 16:05
@JakeHillion JakeHillion changed the title support and test LLVM versions 16 and 17 build and test LLVM version 16 Aug 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (40d3f39) to head (eabe363).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   60.79%   60.79%           
=======================================
  Files         126      126           
  Lines       12493    12493           
  Branches     2014     2014           
=======================================
  Hits         7595     7595           
  Misses       3941     3941           
  Partials      957      957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JakeHillion JakeHillion marked this pull request as ready for review August 19, 2024 10:50
@JakeHillion JakeHillion requested a review from ajor August 21, 2024 14:44
Add LLVM-16 to the Nix builds and CI matrix. Also add the option to explicitly
select an LLVM version so the CircleCI build can still work as before.

We should support at least LLVM-17 currently, but there appears to be a
significant performance regression in compiling the generated code for large
variants that I'm going to debug separately. The long term goal is to support
and test all versions 15 and up.

Test plan:
- CI
CMakeLists.txt Show resolved Hide resolved
@JakeHillion JakeHillion merged commit 8831269 into facebookexperimental:main Aug 21, 2024
16 checks passed
@JakeHillion JakeHillion deleted the pr504 branch August 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants