Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: enable iwyu #263

Closed

Conversation

JakeHillion
Copy link
Contributor

Summary

Enables iwyu on our code, ensuring we include what we use everywhere. Also picks up things like being able to forward declare a struct instead of include the header.

Test plan

  • CI

@JakeHillion JakeHillion force-pushed the iwyu-another-go branch 18 times, most recently from 16097a9 to 920d7bd Compare July 26, 2023 14:06
@JakeHillion
Copy link
Contributor Author

Pushed this to the main repo iwyu branch in case anyone wants to take another crack at it. Closing this PR as I don't intend to land it as is - the behaviour was weird and seemingly wrong.

@JakeHillion JakeHillion deleted the iwyu-another-go branch October 25, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants