Release Note: invalid argument error of __evaluatePureFunction functi…

…on is changed from InvariantError to CompilerDiagnostics Error
facebookarchive · Aug 12, 2018 · 46c30a1 · 46c30a1
1 parent 93d2026
commit 46c30a1
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/src/intrinsics/prepack/global.js b/src/intrinsics/prepack/global.js
@@ -227,14 +227,20 @@ export default function(realm: Realm): void {
       "__evaluatePureFunction",
       0,
       (context, [functionValue]) => {
-        invariant(functionValue instanceof ECMAScriptSourceFunctionValue);
-        invariant(typeof functionValue.$Call === "function");
-        let functionCall: Function = functionValue.$Call;
-        return realm.evaluatePure(
-          () => functionCall(realm.intrinsics.undefined, []),
-          /*bubbles*/ true,
-          /*reportSideEffectFunc*/ null
-        );
+        if (functionValue instanceof ECMAScriptSourceFunctionValue && typeof functionValue.$Call === "function") {
+          let functionCall: Function = functionValue.$Call;
+          return realm.evaluatePure(
+            () => functionCall(realm.intrinsics.undefined, []),
+            /*bubbles*/ true,
+            /*reportSideEffectFunc*/ null
+          );
+        } else {
+          let result = realm.handleError(
+            new CompilerDiagnostic(`CompilerDiagnostic Error`, realm.currentLocation, "PP1005", "Warning")
+          );
+          if (result === "Fail") throw new FatalError("CompilerDiagnostic Error");
+          else return realm.intrinsics.undefined;
+        }
       }
     ),
     writable: true,