Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check-deps actions #236

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Mar 3, 2023

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2023
amyreese added a commit that referenced this pull request Mar 3, 2023
ghstack-source-id: bc597960d3649c9424096d90ea3d46a8820fa428
Pull Request resolved: #236
@amyreese amyreese self-assigned this Mar 3, 2023
@amyreese amyreese merged commit 706d70d into gh/amyreese/1/base Mar 3, 2023
amyreese added a commit that referenced this pull request Mar 3, 2023
ghstack-source-id: bc597960d3649c9424096d90ea3d46a8820fa428
Pull Request resolved: #236
@amyreese amyreese deleted the gh/amyreese/1/head branch March 3, 2023 21:00
@thatch
Copy link
Contributor

thatch commented Mar 12, 2023

Do you have a few words about the rationale? If there are bugs I'd like to fix them.

@amyreese
Copy link
Member Author

@thatch yeah, sorry, meant to follow up with you about that. It looks like the packaging module dropped LegacyVersion in a recent release, and that broke pessimist (and potentially other things), and just needed to get CI passing again on main.

Failures in question happened can be seen in https://github.com/facebook/usort/actions/runs/3796510668

@amyreese
Copy link
Member Author

I just opened python-packaging/pessimist#15 to track that. Happy to reenable here once that's resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants