fix(eslint-plugin-react-compiler): support v9 context api #32045
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
poteto
approved these changes
Jan 13, 2025
compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts
Outdated
Show resolved
Hide resolved
This change fixes a gap in the plugin's support of eslint v9. In one place that it's using the SourceCode api, it's correctly considering v9's api. But in the other place where SourceCode is used, it's only using the legacy api, which was removed in v9.
michaelfaith
force-pushed
the
fix/compiler-plugin-v9-support
branch
from
0642f2f to
4c92a41
Compare
|
Thanks for the quick review. I think I saw mention of there eventually being an effort to merge this plugin with the |
Yeah that's something we're planning on and would appreciate the help! Could you send me a DM on Twitter/bluesky to coordinate? |
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 14, 2025
…2045) ## Summary This change fixes a gap in the plugin's support of eslint v9. In one place that it's using the `SourceCode` api, it's correctly considering v9's api. But in the other place where `SourceCode` is used, it's only using the legacy api, which was removed in v9. DiffTrain build for [b3a95ca](facebook@b3a95ca)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 14, 2025
…2045) ## Summary This change fixes a gap in the plugin's support of eslint v9. In one place that it's using the `SourceCode` api, it's correctly considering v9's api. But in the other place where `SourceCode` is used, it's only using the legacy api, which was removed in v9. DiffTrain build for [b3a95ca](facebook@b3a95ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a gap in the plugin's support of eslint v9. In one place that it's using the
SourceCodeapi, it's correctly considering v9's api. But in the other place whereSourceCodeis used, it's only using the legacy api, which was removed in v9.