create a new object in setState

facebook · Jan 31, 2025 · 113a4f1 · 113a4f1
1 parent c663540
commit 113a4f1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/lexical/src/LexicalNode.ts b/packages/lexical/src/LexicalNode.ts
@@ -243,7 +243,7 @@ export class LexicalNode {
 
   setState<T extends StateKey>(k: T, v: T['value']) {
     const self = this.getWritable();
-    (self.__state as State)[k.key] = v;
+    self.__state = {...self.__state, [k.key]: v};
   }
 
   // Flow doesn't support abstract classes unfortunately, so we can't _force_
@@ -333,6 +333,7 @@ export class LexicalNode {
     this.__parent = prevNode.__parent;
     this.__next = prevNode.__next;
     this.__prev = prevNode.__prev;
+    this.__state = prevNode.__state || {};
   }
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any

diff --git a/packages/lexical/src/__tests__/unit/LexicalNode.test.ts b/packages/lexical/src/__tests__/unit/LexicalNode.test.ts
@@ -1618,11 +1618,10 @@ describe('LexicalNode state', () => {
           type _Test = Expect<
             Equal<
               typeof paragraphObject,
-              | {
-                  readonly bar: number;
-                  readonly foo: string;
-                }
-              | undefined
+              {
+                readonly bar: number;
+                readonly foo: string;
+              }
             >
           >;