fix: issue#2362, build debug version failed with msvc(vs2022 v143) on…

… windows
facebook · Jan 12, 2025 · a2c8fe3 · a2c8fe3
1 parent ac55124
commit a2c8fe3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py
@@ -1289,7 +1289,7 @@ def _build(self, reconfigure) -> None:
                 + [
                     "link=%s" % link,
                     "runtime-link=shared",
-                    "variant=release",
+                    f"variant={self.build_opts.build_type.lower()}",
                     "threading=multi",
                     "debug-symbols=on",
                     "visibility=global",

diff --git a/folly/container/test/heap_vector_types_test.cpp b/folly/container/test/heap_vector_types_test.cpp
@@ -66,6 +66,10 @@ struct OneAtATimePolicy {
 
 template <typename T>
 struct CountingAllocator : std::allocator<T> {
+  CountingAllocator() noexcept = default;
+  template <typename U>
+  CountingAllocator(const CountingAllocator<U>&) noexcept {}
+
   T* allocate(std::size_t n) {
     nAllocations += 1;
     return std::allocator<T>::allocate(n);

diff --git a/folly/test/FunctionRefTest.cpp b/folly/test/FunctionRefTest.cpp
@@ -253,7 +253,7 @@ TEST(FunctionRef, Emptiness) {
   // models std::function
   struct NullptrTestableInSitu {
     int res;
-    [[maybe_unused]] explicit NullptrTestableInSitu(std::nullptr_t);
+    [[maybe_unused]] explicit NullptrTestableInSitu(std::nullptr_t) {}
     explicit NullptrTestableInSitu(int i) : res(i) {}
     CastableToBool operator==(std::nullptr_t) const { return res % 3 != 1; }
     int operator()(int in) const { return res * in; }