Use original JUnit test class name instead of suite class in test XML report #2624
Conversation
|
Hi @swarren12! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Sorry, |
|
Oh, sure. That makes my life a bit easier as well as I can actually build on that branch! (FWIW, #2401 says "We welcome patches to both development and master, but encourage users to stick with master for now." so I assumed either was fine) |
As discussed in #2623, this change will use the original test class name instead of the test suite name when generating the test output XML when run against a JUnit suite. I've based this change on the
devbranch as it doesn't seem the kind of thing that needs to hit the stable branch urgently.I've tried to keep the change as small as possible by overloading the
TestCaseSummaryconstructor to default the newtestSuiteparameter tofalse, so that all the other usages of this aren't affected, but if it's better to push this default up to the places where this class is instantiated then I can do that instead!One thing to note: I originally built this change on top of
master, but figured that it was probably better suited todev. It all seemed to work for me on the stable build, however since rebasing the change onto thedevbranch I can no longer build the project? I don't know if this is because I'm trying to build using the latest Buck release, but it gives me an error parsingbuck/programs/defs.bzl(name 'name' is not defined).