Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documenting Servonk + suggested structure #25

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

madb1lly
Copy link
Contributor

@madb1lly madb1lly commented Jul 5, 2018

@fabricedesre, @novski,
I started preparing a document structure for Servonk a while ago, I probably should have shared this with you earlier.

The main document I've worked on so far is Organisation.md, which will describe the project structure and key files within it. I'm writing it as I learn about and work out how Servonk is built and how it executes - I assume it will be helpful for others like me who are less knowledgeable than you.

Most of the files are currently empty, placeholders for things I think are important. You can compare against @novski's PR and see some overlap, mainly on building on/for Linux.

Feel free to reject the overall PR, I shared it with you mainly for information. Tell me what you think is useful and I'll try and make a PR containing only the files you request.

Cheers :)

madb1lly added 30 commits May 20, 2018 20:22
Add dependencies for bindgen which don't appear to be included in Ubuntu 18.04, servo or B2G dependencies.
More info on Panasonic TVs, and added Redox OS following telegram discussion.
Add link to Panasonic source code.
Since GitHub already has a wiki section of each project it is ambiguous to refer to the "wiki" in the general sense, because people may think we mean the GitHub wiki section instead of another wiki.
Add work in progress devices - macOS and Flame.
Descriptions of rust-toolchain, bootstrap.sh and update-servo.sh.
Merge patch 4 with master
Update my master with Fabrice's
@madb1lly madb1lly mentioned this pull request Jul 5, 2018
@madb1lly
Copy link
Contributor Author

madb1lly commented Oct 2, 2018

@fabricedesre What's is your opinion on the contributions to the docs written by @novski and me?

Copy link
Owner

@fabricedesre fabricedesre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that, it's awesome!

I would not include the files that are just place holders "This will describe..." though. I you want to keep track of what needs to be documented, why not open an issue or add them to the todo.md file?

docs/organisation.md Outdated Show resolved Hide resolved
docs/organisation.md Outdated Show resolved Hide resolved
todo.md Outdated Show resolved Hide resolved
@madb1lly
Copy link
Contributor Author

@fabricedesre I've made the changes, thanks for the detailed check.

The placeholder files are intended to set some structure to which others can contribute. If you prefer not to have a structure then I'll remove from my master branch and update the pull request.

@madb1lly
Copy link
Contributor Author

@fabricedesre I've removed the placeholders, got them in a separate branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants