공지사항 작성 api #9
Merged
공지사항 작성 api #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @PostMapping | ||
| public NoticeDTO writeNotice(@RequestBody @Valid WriteNoticeRequest notice){ |
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
| @ManyToOne(fetch = FetchType.LAZY) |
|
|
||
| public static Notice newNoticeFromReq(WriteNoticeRequest req, List<NoticeImage> images){ | ||
| return Notice.builder() | ||
| .id(req.getId()) |
| this.updatedAt = updatedAt; | ||
| } | ||
|
|
||
| public static Notice newNoticeFromReq(WriteNoticeRequest req, List<NoticeImage> images){ |
There was a problem hiding this comment.
req를 직접 받는 것은 req에 너무 �종속되는 것 같습니다! id, content, images 등등 직접 param을 받는게 더 좋아보입니다.
| @Override | ||
| protected boolean shouldNotFilter(HttpServletRequest request) throws ServletException { | ||
| String uri = request.getRequestURI(); | ||
| return FilterUtil.excludeUrlPatterns.contains(uri); |
There was a problem hiding this comment.
Util로 쓰려면 상수보다는 method로 만들어 FilterUtil.isExcludePatterns(uri); 요런 방식이 더 좋아보입니다!
| @Table(name = "notice") | ||
| public class Notice { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) |
There was a problem hiding this comment.
Id들을 Long타입이 아닌, Id객체로 만드는 것이 좋아보입니다! 어떻게 하면 될까요?
There was a problem hiding this comment.
id만 따로 객체로 관리해야하는 거라면 @embeddable, @EmbeddedId를 사용하면 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.