JWT refresh 로직 추가 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-Tailor
suggested changes
Sep 23, 2024
| userInfo.put("name", user.getName()); | ||
| userInfo.put("loginId", user.getLoginId()); | ||
| UserInfo userInfo = new UserInfo(); | ||
| userInfo.setName(user.getName()); |
There was a problem hiding this comment.
constructor를 만드는게 아니라 set으로 한 이유가 있을까요?
|
|
||
| @PostMapping | ||
| public ResponseEntity<JWToken> renweAccessToken(@RequestBody JWToken token){ | ||
| return new ResponseEntity<JWToken>(jwtService.renewAccessToken(token.getRefreshToken()), HttpStatus.OK); |
There was a problem hiding this comment.
return을 꼭 ResponseEntity로 감쌀 필요가 있을까요?
| userInfo.setName(user.getName()); | ||
| userInfo.setLoginId(user.getLoginId()); | ||
|
|
||
| if(jwtClaims.getExpiration().before(new Date())){ // refreshToken이 만료되지 않은 경우 accessToken만 생성 |
There was a problem hiding this comment.
if 안에 if가 있는 로직은 지양하는 것이 좋습니다. 어떻게 바꾸는게 좋을까요?
| if(jwtClaims.getExpiration().before(new Date())){ // refreshToken이 만료되지 않은 경우 accessToken만 생성 | ||
| token.setAccessToken(createAccessToken(userInfo)); | ||
| return token; | ||
| }else{ // refreshToken이 만료된 경우 access,refreshToken 둘 다 생성 |
| @@ -13,5 +12,6 @@ public interface UserRepository extends JpaRepository<User, Long> { | |||
| public List<User> findAll(); | |||
| public Optional<User> findByLoginId(String loginId); | |||
| public Optional<User> findByLoginIdAndPassword(String loginId, String password); | |||
| public Optional<User> findByRefreshToken(String refreshToken); | |||
There was a problem hiding this comment.
User 객체를 보니 Refreshtoken이나 LoginId 등 unique 가 안되어 있는 것 같은데, 만약 같은 Refreshtoken값을 가진 유저가 생기면 어떻게 될까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWT refresh 로직 추가