Add cop for time in expect #127
Open
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitamBanerjee
requested review from
maudineormsby and
jbeard6
and removed request for
a team
RitamBanerjee
force-pushed
the
add_time_in_assert_cop
branch
from
ef89a6c
to
9db62cb
Compare
jmpage
reviewed
Dec 20, 2023
|
Very nice! |
jaeger401
reviewed
Jan 3, 2024
There was a problem hiding this comment.
LGTM. In ez-rails, we've traditionally encouraged the use of :freeze_time to mitigate this, but it makes sense to add safety to our other code bases which may not have a spec helper like that. (And this should help limit flakiness in ez-rails too.)
I concur with Jen -- could you please update CHANGELOG.md, version.rb, and the README? Happy to approve once those are updated!
jbeard6
reviewed
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
We don't want people asserting on a call to
TimeWhy are we doing this?
This leads to flaky time bomb tests
How was it tested?