Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification preview item(s) for newly come notifications #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luriusTM
Copy link
Contributor

@luriusTM luriusTM commented Oct 22, 2024

Currently it is not configurable.

Cunfiguration options:

  • Do it or not.
  • Show time before disappearing

Current work:
New notification will be displayed on a bubble, like the notifications, but it is visible, if the notifications themselves are not.
image

(root theme, which made a toolbar look a bit different, is not target of the commit it just visible on the screenshot.)

The new notification will be visible only for 10 seconds after that they are swiped out.

Features like in notification: you can close it on preview.

Modules are not changed entirely ^^ coparer got crazy, only new popup came in with a React.Fragment.

Solves issue: #55
Although i think this is a feature request not a bug...

@eythaann
Copy link
Owner

nice, thanks for this I currently really busy so I was not able to fix this on these week.
can you send a video showing how it is looking?.

@luriusTM
Copy link
Contributor Author

luriusTM commented Oct 22, 2024

nice, thanks for this I currently really busy so I was not able to fix this on these week. can you send a video showing how it is looking?.

Recording.2024-10-22.143406.mp4

Looks like this...
(would do a normal video, but im not big fun of recording i only knows the snipping tool, but as much, my screen is 3k a 20 secound video is 50MB...) and a 7z does not alowed here 😢

@eythaann
Copy link
Owner

Looks like this

nice with motion you can also animate the start of the notification not only the exit, do the same animation but inverted.

@luriusTM luriusTM force-pushed the feature/NotificationPreview branch 2 times, most recently from 0156e25 to 0ed7e23 Compare October 22, 2024 15:01
@PhantomPixel-0418
Copy link
Contributor

I think this is a great feature! But is it possible to load the image from the notification in the popup bubble?🙂

@eythaann
Copy link
Owner

I think this is a great feature! But is it possible to load the image from the notification in the popup bubble?🙂

I have to investigate more on the notifications api of windows to see if it is posible (I know it is). btw this request doesn't have to be with this pull request like this is just using the already exposed variables on the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants