fix: readme/tinygo examples use go:wasmexport/wasmimport, -buildmode=c-shared #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evacchi
requested review from
zshipko,
nilslice and
mhmd-azeez
as code owners
…c-shared Signed-off-by: Edoardo Vacchi <[email protected]>
evacchi
force-pushed
the
tinygo-readme
branch
from
f82b09e to
4f26acc
Compare
mhmd-azeez
approved these changes
Jan 23, 2025
README.md
Outdated
| @@ -68,7 +68,7 @@ platform. | |||
| Compile this with the command: | |||
|
|
|||
| ```bash | |||
| tinygo build -o plugin.wasm -target wasi main.go | |||
| tinygo build -o plugin.wasm -target wasip1 main.go | |||
There was a problem hiding this comment.
Is there any harm in using -buildmode c-shared here also, since this is also a reactor module
There was a problem hiding this comment.
no, but the example above has a main() but you might be right because I think the issue the user on Discord had was precisely that even though they had a main TinyGo default to a reactor 🤔
There was a problem hiding this comment.
I have updated the readme to use //go:wasmexport everywhere and -buildmode=c-shared here
Signed-off-by: Edoardo Vacchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have kept the examples with
//exportbecause this will work on both Tiny and Big Go. Once the new Go version is out we can change them all to//go:wasmexport. Notice that the-buildmode=c-sharedflag and the//go:wasmexportat that point will be aligned in semantics in both compilers, see golang/go#65199