Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nonAPI.txt #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update nonAPI.txt #252

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2024

Please review the diff and run /bindings command manually.

@CGMossa
Copy link
Member

CGMossa commented Jul 1, 2024

@JosiahParry the non api has already changed. I think it is time to contact CRAN.

@yutannihilation
Copy link
Contributor

yutannihilation commented Jul 1, 2024

These are affected:

https://github.com/extendr/extendr/blob/d39d1d09ea024a31c3331a754baeafe3c7ae5b0e/extendr-api/src/robj/rinternals.rs#L358
https://github.com/extendr/extendr/blob/d39d1d09ea024a31c3331a754baeafe3c7ae5b0e/extendr-api/src/robj/rinternals.rs#L363

Btw, I thought what CRAN requested to remove were only PRSEEN and SYMVALUE. Isn't it that this matters only for new submissions? (Let me correct a bit. I thought it's something that the package author eventually address, but not what is considered the direct cause of immediate removal.)

@CGMossa CGMossa mentioned this pull request Jul 1, 2024
@CGMossa
Copy link
Member

CGMossa commented Jul 1, 2024

I don't know what is going on with CRAN and what they are doing to packages. In any case, I've made a PR that manually removes these from the cached bindings. Hopefully, not more chaos will ensue before we get xtask up and running. #253

@yutannihilation
Copy link
Contributor

The "non-API" Note doesn't always mean the death sentence from CRAN. For example, there's no label of "issues need fixing before ..." on vctrs even though the CRAN check displays the Note.

https://cran.r-project.org/web/packages/vctrs/index.html
https://cran.r-project.org/web/checks/check_results_vctrs.html

So, I thought the difference is this part.

This entry point may be removed soon.

For example, duckdb gets "issues need fixing before ..." while it has only one non-API Note.

https://cran.r-project.org/web/checks/check_results_duckdb.html

@CGMossa
Copy link
Member

CGMossa commented Jul 1, 2024

Thanks! Let me know what you think I should do next.

@yutannihilation
Copy link
Contributor

I think you can go ahead with #253 but it's not very urgent if it's not the hard requirement from CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants