-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add minimum nodejs version in docs #1495
Merged
crandmck
merged 8 commits into
expressjs:gh-pages
from
inigomarquinez:docs/min-nodejs-version
May 2, 2024
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8e9b96a
docs: add minimum nodejs version in faq
inigomarquinez d6b19c6
docs: add reference to nodejs minimum version in installing guide
inigomarquinez 204ceb8
docs: add minimum nodejs version for 4.x api
inigomarquinez e69d4aa
docs: add minimum nodejs version for 5.x api
inigomarquinez 9631a68
docs: use present tense as suggested by Rand
inigomarquinez db9404e
docs: improve faq title as suggested by Rand
inigomarquinez ee55cf0
chore: remove faq anchor as it's no longer needed
inigomarquinez de5a3c5
docs: add node version required in the installing section as suggeste…
inigomarquinez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,4 +90,11 @@ If you have a specific file, use the `res.sendFile()` function. | |
If you are serving many assets from a directory, use the `express.static()` | ||
middleware function. | ||
|
||
<a name="which-is-the-minimum-version-of-nodejs-that-express-supports"></a> | ||
|
||
## Which is the minimum version of Node.js that Express supports? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "What version of Node.js does Express require?" Elsewhere you use "require" instead of "support", which is preferable IMO. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
* [Express 4.x](/{{ page.lang }}/4x/api.html) requires Node.js 0.10 or higher. | ||
* [Express 5.x](/{{ page.lang }}/5x/api.html) will require Node.js 18 or higher. | ||
|
||
### [Previous: More examples ](/{{ page.lang }}/starter/examples.html) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Express 5.0 requires..."
Since 5.x is available now (in beta) it should be present tense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crandmck !
Change added here