-
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use loop for acceptParams (4.x backport) #6176
base: 4.x
Are you sure you want to change the base?
Use loop for acceptParams (4.x backport) #6176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is annoying, but we should continue checking to ensure the history file is updated until we can automate it. That should have been done in the original as well, but too late now.
I thought about updating the history file. But there's no API or dep change, and no one requested the change after 1 month of it sitting open |
044d0a9
to
585a3f1
Compare
Sure, but it is "the process". We absolutely should change the process, but until we do it is easy to add and ensures folks doing the release dont forget anything. |
pr for it incoming edit: #6177 |
cherry-pick #6066 into 4.x
#6066 (comment)
Not worth a release on its own, but when it's as easy a cherry-pick and no other changes, hard not to backport.