Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade debug dep from 3.10 to 4.3.6 #5829

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

carpasse
Copy link
Contributor

Related discussion: expressjs/discussions#256

@carpasse
Copy link
Contributor Author

CI/CD is failing for old versions of node.
I believe it is ok to ignore these errors because version 5.0 will drop support for nodejs version below 18

@wesleytodd @UlisesGascon Can you please confirm it is ok to ignore them?

@IamLizu
Copy link
Member

IamLizu commented Aug 16, 2024

I think these CI errors will be sorted by #5595

I think we need to look here while upgrading the dependencies, #5595 (comment)

Edit: I am a bit unclear on whether it is okay or not after reading comments from above PR. It was supposed to drop versions before 18 in CI. But it appears the team wants to do it later.

@carpasse
Copy link
Contributor Author

carpasse commented Aug 16, 2024

@IamLizu thanks for pointing #5595 (comment)

@wesleytodd debug dropped support to nodejs 4 on version 4.0.0 How should I mark this change as a breaking change then? If so, should I use conventional commits BREAKING CHANGE to mark the change?

@wesleytodd
Copy link
Member

Can you please confirm it is ok to ignore them?

Yep! See the comment I just made in #5830.

@wesleytodd wesleytodd merged commit 41c054c into expressjs:5.0 Aug 17, 2024
12 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants