Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 5.0 CI, drop CI jobs under node 18 #5801

Closed
wants to merge 4 commits into from
Closed

Update 5.0 CI, drop CI jobs under node 18 #5801

wants to merge 4 commits into from

Conversation

jonchurch
Copy link
Member

@jonchurch jonchurch commented Aug 1, 2024 •
edited
Loading

From master:

  • brings the reworked cross platform windows/linux CI to 5.0 (which also removed minor pinning in our node versions)
  • skip QUERY tests in Node 21

Net new:

  • drop node versions below 18 from CI
  • deletes appveyor.yml which I forgot to do in master

@UlisesGascon you can update your PR #5595 to just be engines change if this PR lands

@jonchurch jonchurch requested a review from a team August 1, 2024 23:30
@wesleytodd
Copy link
Member

@ctcpip do you think this also addresses the reason you were rebasing the 5.0 branch in #5785?

@UlisesGascon UlisesGascon mentioned this pull request Aug 2, 2024
Merged
UlisesGascon
UlisesGascon approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! #5803 landed already 🥳

@jonchurch jonchurch closed this Aug 2, 2024
@jonchurch
Copy link
Member Author

Some shuffles happening and sequencing, closed this so we can land the master merge into 5.0 then focus on new commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonchurch @wesleytodd @UlisesGascon