Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for brotli #194

Merged
merged 36 commits into from
Jan 8, 2025
Merged

feat: support for brotli #194

merged 36 commits into from
Jan 8, 2025

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Oct 19, 2024 •
edited
Loading

The changes from #172 are brought in, with the exception of using the accept negotiation logic.

danielgindi and others added 18 commits July 10, 2020 12:47
@danielgindi
Added support for brotli ('br') content-encoding
5bdbb9e
@danielgindi
Update README.md
6ef8cef
@danielgindi
Update README.md
02c06c2
@danielgindi
Update README.md
4df713b
@danielgindi
Apply default value also when params is specified
87076af
@danielgindi
Increase coverage for specifying params
fffe4c7
@danielgindi
Updated brotli detection method
9145a55
@danielgindi
Prefer br over gzip and deflate
0bb402e
@nicksrandall @danielgindi
feat: use "koa-compress" logic to determine the preferred encoding
bbcd9c4
@nicksrandall @danielgindi
test: adding one more test case br/gzip with quality params
767c62a
@nicksrandall @danielgindi
chore: fix linting errors
78ad84a
@nicksrandall @danielgindi
fix: hand write encodings lib to be compatible with node 0.8
4c359b8
@nicksrandall @danielgindi
Fix: fixing lint errors in new lib
8340cde
@nicksrandall @danielgindi
Fix: fixing lint errors in new lib
04ab713
@danielgindi
implemented required encoding negotiator without 3rd party dependency
b024cce
@bjohansebas
Merge branch 'master' into feature/brotli
9af45dd
@bjohansebas
fix
25b68b8
@bjohansebas
use negotiator
3d30ab0
@bjohansebas
Copy link
Member Author

It should use accepts, so this PR is not ready yet, and I don't have the option to turn it into a draft. I will soon open a PR in accepts to be able to use this logic

@bjohansebas bjohansebas self-assigned this Oct 19, 2024
@UlisesGascon UlisesGascon requested a review from a team October 20, 2024 17:24
@bjohansebas bjohansebas marked this pull request as draft October 22, 2024 21:07
@bjohansebas bjohansebas mentioned this pull request Oct 22, 2024
Closed
blakeembrey
blakeembrey approved these changes Oct 23, 2024
View reviewed changes
encoding_negotiator.js Outdated Show resolved Hide resolved
@bjohansebas bjohansebas marked this pull request as ready for review October 24, 2024 00:17
@blakeembrey blakeembrey mentioned this pull request Oct 24, 2024
Merged
@bjohansebas
Copy link
Member Author

I really don't think there are any more changes to be made here.

@bjohansebas

This comment was marked as outdated.

Sign in to view
@bjohansebas bjohansebas marked this pull request as draft December 5, 2024 16:51
@bjohansebas bjohansebas force-pushed the feature/brotli branch 2 times, most recently from ae9da60 to 162f14b Compare December 5, 2024 19:12
@bjohansebas bjohansebas marked this pull request as ready for review December 5, 2024 19:13
nscuilla-godaddy
nscuilla-godaddy reviewed Dec 6, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
blakeembrey
blakeembrey reviewed Dec 6, 2024
View reviewed changes
index.js Show resolved Hide resolved
This was referenced Dec 17, 2024
Closed
Open
@Kle0s
Copy link

Kle0s commented Dec 23, 2024

@wesleytodd any chance you have the time to review it once again so it could be merged?

@kapilaggar
Copy link

@bjohansebas @blakeembrey any idea when this PR will be merged and new version will be released?

@github-actions github-actions bot mentioned this pull request Dec 31, 2024
Closed
wesleytodd
wesleytodd approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets merge and I will add this to the list of thing to prepare releases for in the next few weeks.

@wesleytodd wesleytodd merged commit d272132 into expressjs:master Jan 8, 2025
29 checks passed
@bjohansebas bjohansebas deleted the feature/brotli branch January 8, 2025 20:38
@bjohansebas
Copy link
Member Author

Thanks to everyone who made this possible

This was referenced Jan 8, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuilla-godaddy nscuilla-godaddy nscuilla-godaddy left review comments

@blakeembrey blakeembrey blakeembrey approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

@UlisesGascon UlisesGascon Awaiting requested review from UlisesGascon

Assignees

@bjohansebas bjohansebas

Labels
semver-minor tc agenda
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.