Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devDependency safe-buffer #547

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Phillip9587
Copy link
Contributor

This PR removes the safe-buffer package from devDependencies as it's no longer needed. Since we no longer support Node.js versions older than 18.0.0, the native Buffer class now fully handles security concerns. Additionally, there are no instances of new Buffer(...) usage in the repository.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will add the @expressjs/security-wg add reviewer too.

@UlisesGascon
Copy link
Member

We probably want to reflect this change in the HISTORY.md file.

@Phillip9587
Copy link
Contributor Author

We probably want to reflect this change in the HISTORY.md file.

Is it necessary for a devDependency?

@UlisesGascon
Copy link
Member

Is it necessary for a devDependency?

Oh! you are right, forget my last comment :)

@UlisesGascon UlisesGascon merged commit 51e90e7 into expressjs:master Oct 31, 2024
4 checks passed
@Phillip9587 Phillip9587 deleted the remove-safe-buffer branch October 31, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants