-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for brotli ('br') content-encoding #406
Conversation
How are we doing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @danielgindi!
Thanks fo the links attached to the PR. I will love to be able to try that compression in my next project 💪
Yeah this brotli is truly amazing :) Btw we have a PR in the compression repo, to allow responses to be encoded too. It's two sides of the same coin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved over one comment that was still outstanding from the first repo and a general comment to make sure our detection makes sense from the noode.js project.
@dougwilson Have you noticed that we suddenly have a "leak" in the older node versions in CI? |
@dougwilson Anything preventing this from being published? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
** spam content removed **
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
** spam content removed **
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
** spam content removed **
0ad1d88
to
2a2f471
Compare
Is this feature stuck for some specific reason? Is there something that can be done to fix it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@danielgindi I re-targeted this to the 2.0 branch where we are preparing the major release for use in |
9f5310b
to
69e7f71
Compare
expressjs/compression#172
https://medium.com/oyotech/how-brotli-compression-gave-us-37-latency-improvement-14d41e50fee4
https://caniuse.com/#feat=brotli
(Originally #403)