Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use the qs module for the simple parser #387

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

papandreou
Copy link
Contributor

Following up from #326

@wesleytodd
Copy link
Member

We are preparing to release 2.0, and to reduce churn and help us I retargeted this to that branch. Would you be able to rebase this so I can merge it there?

@papandreou
Copy link
Contributor Author

@wesleytodd, absolutely! Done.

@wesleytodd
Copy link
Member

Before I merge this, @ljharb mind taking a quick look to make sure this is good to land for v5? It appears your last comment was in 2020 just mentioning to update, which we will for sure ensure we are before publishing.

@ljharb
Copy link
Contributor

ljharb commented Jul 24, 2024

still LGTM!

@wesleytodd wesleytodd merged commit 7eb00cd into expressjs:2.x Jul 24, 2024
4 checks passed
papandreou added a commit to papandreou/body-parser that referenced this pull request Jul 27, 2024
* 2.x: (98 commits)
  fix(deps): raw-body@^3.0.0 (expressjs#529)
  Also use the qs module for the simple parser (expressjs#387)
  feat!: remove node less than 18 from ci
  2.0.0-beta.2
  docs: add missing history entry
  tests: enable strict mode
  Remove deprecated bodyParser() combination middleware
  build: remove conditional code coverage
  deps: [email protected]
  deps: [email protected]
  deps: [email protected]
  1.20.2
  Fix strict json error message on Node.js 19+
  deps: [email protected]
  build: [email protected]
  build: [email protected]
  build: [email protected]
  deps: content-type@~1.0.5
  build: [email protected]
  build: [email protected]
  ...
papandreou added a commit to papandreou/body-parser that referenced this pull request Jul 27, 2024
* 2.x: (98 commits)
  fix(deps): raw-body@^3.0.0 (expressjs#529)
  Also use the qs module for the simple parser (expressjs#387)
  feat!: remove node less than 18 from ci
  2.0.0-beta.2
  docs: add missing history entry
  tests: enable strict mode
  Remove deprecated bodyParser() combination middleware
  build: remove conditional code coverage
  deps: [email protected]
  deps: [email protected]
  deps: [email protected]
  1.20.2
  Fix strict json error message on Node.js 19+
  deps: [email protected]
  build: [email protected]
  build: [email protected]
  build: [email protected]
  deps: content-type@~1.0.5
  build: [email protected]
  build: [email protected]
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants