express42 · ekohl · Dec 29, 2023 · Dec 29, 2023 · Dec 29, 2023 · Dec 29, 2023
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -1,14 +1,17 @@
 name: CI
 
+env:
+  BUNDLE_WITHOUT: development
+
 on:
   push:
     branches:
-    - $default-branch
+    - master
     paths-ignore:
     - '**.md'
   pull_request:
     branches:
-    - $default-branch
+    - master
     paths-ignore:
     - '**.md'
 
@@ -54,20 +57,12 @@ jobs:
           ZBX_SERVER_HOST: zabbix-server
           PHP_TZ: "US/Eastern"
     steps:
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1 # actions/setup-ruby@v1
+    - uses: actions/checkout@v4
+    - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
-    - uses: actions/cache@v2
-      with:
-        path: vendor/bundle
-        key: ${{ matrix.ruby }}-gems-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ matrix.ruby }}-gems-
-    - name: Bundle install
-      run: |
-        gem list --silent -i bundler -v '~> 2' || gem install bundler -v '~> 2' --no-document
-        bundle config path vendor/bundle
-        bundle install --without development --jobs 4 --retry 3
+        bundler-cache: true
     - name: Run tests
-      run: bundle exec rspec ./spec/*
+      run: bundle exec rake spec
+      env:
+        ZABBIX_RUN_ACCEPTANCE: true
diff --git a/Rakefile b/Rakefile
@@ -12,14 +12,20 @@ RuboCop::RakeTask.new
 require 'yard'
 YARD::Rake::YardocTask.new
 
-require 'yardstick/rake/measurement'
-Yardstick::Rake::Measurement.new do |measurement|
-  measurement.output = 'measurement/report.txt'
-end
+task default: [:spec, :rubocop]
 
-require 'yardstick/rake/verify'
-Yardstick::Rake::Verify.new do |verify|
-  verify.threshold = 67.1
-end
+begin
+  require 'yardstick/rake/measurement'
+  Yardstick::Rake::Measurement.new do |measurement|
+    measurement.output = 'measurement/report.txt'
+  end
 
-task default: [:spec, :rubocop, :verify_measurements]
+  require 'yardstick/rake/verify'
+  Yardstick::Rake::Verify.new do |verify|
+    verify.threshold = 67.1
+  end
+
+  Rake::Task[:default].enhance(:verify_measurements)
+rescue LoadError
+  # yardstick not present
+end
diff --git a/spec/action.rb → spec/acceptance/action_spec.rb b/spec/action.rb → spec/acceptance/action_spec.rb
diff --git a/spec/application.rb → spec/acceptance/application_spec.rb b/spec/application.rb → spec/acceptance/application_spec.rb
diff --git a/spec/basic_func.rb → spec/acceptance/basic_func_spec.rb b/spec/basic_func.rb → spec/acceptance/basic_func_spec.rb
diff --git a/spec/configuration.rb → spec/acceptance/configuration_spec.rb b/spec/configuration.rb → spec/acceptance/configuration_spec.rb
diff --git a/spec/drule.rb → spec/acceptance/drule_spec.rb b/spec/drule.rb → spec/acceptance/drule_spec.rb
diff --git a/spec/event.rb → spec/acceptance/event_spec.rb b/spec/event.rb → spec/acceptance/event_spec.rb
diff --git a/spec/graph.rb → spec/acceptance/graph_spec.rb b/spec/graph.rb → spec/acceptance/graph_spec.rb
diff --git a/spec/host.rb → spec/acceptance/host_spec.rb b/spec/host.rb → spec/acceptance/host_spec.rb
diff --git a/spec/hostgroup.rb → spec/acceptance/hostgroup_spec.rb b/spec/hostgroup.rb → spec/acceptance/hostgroup_spec.rb
diff --git a/spec/httptest.rb → spec/acceptance/httptest_spec.rb b/spec/httptest.rb → spec/acceptance/httptest_spec.rb
diff --git a/spec/item.rb → spec/acceptance/item_spec.rb b/spec/item.rb → spec/acceptance/item_spec.rb
diff --git a/spec/maintenance.rb → spec/acceptance/maintenance_spec.rb b/spec/maintenance.rb → spec/acceptance/maintenance_spec.rb
diff --git a/spec/mediatype.rb → spec/acceptance/mediatype_spec.rb b/spec/mediatype.rb → spec/acceptance/mediatype_spec.rb
diff --git a/spec/problem.rb → spec/acceptance/problem_spec.rb b/spec/problem.rb → spec/acceptance/problem_spec.rb
diff --git a/spec/query.rb → spec/acceptance/query_spec.rb b/spec/query.rb → spec/acceptance/query_spec.rb
diff --git a/spec/screen.rb → spec/acceptance/screen_spec.rb b/spec/screen.rb → spec/acceptance/screen_spec.rb
diff --git a/spec/script.rb → spec/acceptance/script_spec.rb b/spec/script.rb → spec/acceptance/script_spec.rb
diff --git a/spec/server.rb → spec/acceptance/server_spec.rb b/spec/server.rb → spec/acceptance/server_spec.rb
diff --git a/spec/template.rb → spec/acceptance/template_spec.rb b/spec/template.rb → spec/acceptance/template_spec.rb
diff --git a/spec/trigger.rb → spec/acceptance/trigger_spec.rb b/spec/trigger.rb → spec/acceptance/trigger_spec.rb
diff --git a/spec/user.rb → spec/acceptance/user_spec.rb b/spec/user.rb → spec/acceptance/user_spec.rb
diff --git a/spec/usergroup.rb → spec/acceptance/usergroup_spec.rb b/spec/usergroup.rb → spec/acceptance/usergroup_spec.rb
diff --git a/spec/usermacro.rb → spec/acceptance/usermacro_spec.rb b/spec/usermacro.rb → spec/acceptance/usermacro_spec.rb
diff --git a/spec/valuemap.rb → spec/acceptance/valuemap_spec.rb b/spec/valuemap.rb → spec/acceptance/valuemap_spec.rb
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,5 +1,16 @@
 require 'zabbixapi'
 
+RSpec.configure do |config|
+  config.define_derived_metadata(file_path: %r{/spec/acceptance/}) do |metadata|
+    metadata[:type] = :acceptance
+  end
+
+  # Don't run acceptance tests unless a host is provided
+  unless (ENV.key?('ZABBIX_HOST_URL') || ENV.key?('ZABBIX_RUN_ACCEPTANCE'))
+    config.filter_run_excluding type: :acceptance
+  end
+end
+
 def zbx
   # settings
   @api_url = ENV['ZABBIX_HOST_URL'] || 'http://localhost:8080/api_jsonrpc.php'