Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-native-dynamic-app-icon): add exact ipad sizes 152/167 for exported icons #233

Merged
merged 6 commits into from
May 7, 2024
Merged

fix(react-native-dynamic-app-icon): add exact ipad sizes 152/167 for exported icons #233

merged 6 commits into from
May 7, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented May 3, 2024 •
edited
Loading

Why

This is an attempt to satisfy Apple's request for dynamic app icons on iPad, using sizes 152x152 and 167x167.

How

  • Replaced fixed size and scales with IconDimension
  • Added iPad specific icon dimensions, turning on/off based on ios.supportsTablets

Test Plan

  • Run example app apps/react-native-dynamic-app-icon
    • iPad support is now enabled
  • Verify that iPad icons are exported + registered, and plist contains right icon info

@byCedric byCedric marked this pull request as ready for review May 7, 2024 16:34
@byCedric byCedric requested a review from EvanBacon May 7, 2024 16:36
@EvanBacon EvanBacon merged commit bc6856f into main May 7, 2024
9 checks passed
@EvanBacon EvanBacon deleted the @bycedric/fix/dynamic-app-icon-sizes-ipad branch May 7, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon Awaiting requested review from EvanBacon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byCedric @EvanBacon