Rename console command Test to LookupTest #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our pipeline, we ran into this error;
For extra security, we run
composer dump --classmap-authoritativein our pipeline, creating a classmap for all classes in the project. However, Magento by default excludes Tests from the classmap, see here.This usually isn't a problem since Tests shouldn't be referenced by production code anyway. However in this case, Composer thinks the console command named "Test" is in fact a test, and skips this class when creating the classmap, causing the Uncaught Error Class not found to occur.
Simply renaming Test to something else fixes this. I've named it LookupTest here, since that is what it does. I've kept the command itself (
bin/magento experius_postcode:test) the same for backwards compatibility.