Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement site layout for mycraft, engage and intranet sites - EXO-67424 - Meeds-io/MIPs#88 #88

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

GouadriaHanen
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Nov 17, 2023
<container id="middle-topBar-container" template="system:/groovy/portal/webui/container/UIAddOnContainer.gtmpl">
<portlet-application>
<portlet>
<application-ref>social-portlet</application-ref>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format code of the whole file

<page-body> </page-body>
<container id="UITopBarContainer" template="system:/groovy/portal/webui/container/UITopBarContainer.gtmpl">
<access-permissions>*:/platform/users;*:/platform/externals</access-permissions>
<container id="left-topBar-container" template="system:/groovy/portal/webui/container/UIAddOnContainer.gtmpl" attribute="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute="" is it needed ?

@@ -32,6 +32,46 @@
<entry key="showPortletInfo">0</entry>
</properties>
<portal-layout>
<page-body> </page-body>
<container id="UITopBarContainer" template="system:/groovy/portal/webui/container/UITopBarContainer.gtmpl">
<access-permissions>*:/platform/users;*:/platform/externals</access-permissions>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format code of the whole file

@@ -32,6 +32,46 @@
<entry key="showPortletInfo">0</entry>
</properties>
<portal-layout>
<page-body> </page-body>
<container id="UITopBarContainer" template="system:/groovy/portal/webui/container/UITopBarContainer.gtmpl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format code of the whole file

Comment on lines 1 to 7
#left-topBar-containerChildren{
display: flex !important;
}
.left-topBar-containerTDContainer{
margin-left: 0 ~'!important; /** orientation=lt */ ';
margin-right: 0 ~'!important; /** orientation=rt */ ';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#left-topBar-containerChildren{
display: flex !important;
}
.left-topBar-containerTDContainer{
margin-left: 0 ~'!important; /** orientation=lt */ ';
margin-right: 0 ~'!important; /** orientation=rt */ ';
}
#left-topBar-containerChildren {
display: flex !important;
}
.left-topBar-containerTDContainer {
margin-left: 0 ~'!important; /** orientation=lt */ ';
margin-right: 0 ~'!important; /** orientation=rt */ ';
}

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azayati azayati changed the title feat: Implement top bar container for sites : mycraft , engage and intranet - EXO-67424 - Meeds-io/MIPs#88 feat: Implement site layout for mycraft, engage and intranet sites - EXO-67424 - Meeds-io/MIPs#88 Nov 21, 2023
@azayati azayati merged commit 43a6725 into feature/experience Nov 21, 2023
6 checks passed
@azayati azayati deleted the EXO-67424 branch November 21, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants