Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure DW site default navigation - EXO-65024_EXO-65400 - Meeds-io/MIPs#72 #67

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

GouadriaHanen
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -19,3 +19,6 @@
portal.dw.home=Snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this label ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it shouldn't for the existing data case

@@ -19,3 +19,6 @@
portal.dw.home=Snapshot
portal.dw.externalHome=Home
portal.dw.overview=Participate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this label ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@azayati azayati changed the title feat: DW site default navigations - EXO-65024 - Meeds-io/MIPs#72 feat: DW site default navigations - EXO-65024_EXO-65400 - Meeds-io/MIPs#72 Aug 24, 2023
@azayati azayati changed the title feat: DW site default navigations - EXO-65024_EXO-65400 - Meeds-io/MIPs#72 feat: Configure DW site default navigations - EXO-65024_EXO-65400 - Meeds-io/MIPs#72 Aug 24, 2023
@azayati azayati changed the title feat: Configure DW site default navigations - EXO-65024_EXO-65400 - Meeds-io/MIPs#72 feat: Configure DW site default navigation - EXO-65024_EXO-65400 - Meeds-io/MIPs#72 Aug 24, 2023
@azayati azayati enabled auto-merge (squash) August 24, 2023 12:33
Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azayati azayati merged commit f1ebace into develop Aug 24, 2023
9 checks passed
@azayati azayati deleted the todevelop-1 branch August 24, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants