Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local storage for caching MS tokens to avoid frequent logins - EXO-65633 #80

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented Sep 13, 2023

Priori to this fix, users were requested to login each few moments because their tokens get expired soon.
This change will cache tokens in local storage of the browser instead of the session to make them reusable and enhance the UX
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/caching.md

@ahamdi ahamdi self-assigned this Sep 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@exo-swf exo-swf added the partialCIBuild Perform Partial CI Build label Sep 13, 2023
@ahamdi ahamdi merged commit 13e3f97 into feature/maintenance Sep 13, 2023
7 checks passed
@ahamdi ahamdi deleted the fix/EXO-65633 branch September 13, 2023 10:03
ahamdi added a commit that referenced this pull request Sep 21, 2023
EXO-65633 (#80)

Priori to this fix, users were requested to login each few moments because their tokens get expired soon.
This change will cache tokens in local storage of the browser instead of the session to make them reusable and enhance the UX
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/caching.md
ahamdi added a commit that referenced this pull request Sep 21, 2023
EXO-65633 (#80)

Priori to this fix, users were requested to login each few moments because their tokens get expired soon.
This change will cache tokens in local storage of the browser instead of the session to make them reusable and enhance the UX
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/caching.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants