feat: take starry out of experimental #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch tests folder structure
for more information, see https://pre-commit.ci
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
for more information, see https://pre-commit.ci
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
for more information, see https://pre-commit.ci
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
for more information, see https://pre-commit.ci
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
for more information, see https://pre-commit.ci
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
for more information, see https://pre-commit.ci
7 tasks
|
I would like to make the following tutorials before merging and releasing:
|
I'll do this. I have a notebook that I just need to add some comments to for it to become a tutorial. |
|
Great! I think it would be nice in the tutorial to show (%timeit) how well the approach scales with the number of wavelengths as it seems to be the concern raised in #164. |
for more information, see https://pre-commit.ci
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
for more information, see https://pre-commit.ci
|
I ended up copying the units tutorial from @dfm in branch units-tutorial. Dan, anything you thing would be good to add? ps: I've attached units to starry Surfaces in starry-units, I'll PR after this one |
dfm
approved these changes
Oct 19, 2024
dfm
approved these changes
Nov 3, 2024
…exoplanet-dev/jaxoplanet into feat-starry-out-of-experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take starry out of experimental, turned into
jaxoplanet.starryI created a
jaxoplanet.starry.coremodule and adapted the directories of the tests to the new structure