Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a multi-precision module for testing #210

Merged
merged 27 commits into from
Sep 12, 2024
Merged

feat: add a multi-precision module for testing #210

merged 27 commits into from
Sep 12, 2024

Conversation

lgrcia
Copy link
Collaborator

@lgrcia lgrcia commented Sep 4, 2024

This adds a multi-precision module to compute all starry quantities using the mpmath package with arbitrary precision.

@lgrcia lgrcia added the enhancement New feature or request label Sep 4, 2024
@soichiro-hattori
Copy link
Collaborator

@lgrcia: I'm happy for this to be merged!
Will these module need to be documented or is it only going to be used for testing?

@lgrcia
Copy link
Collaborator Author

lgrcia commented Sep 5, 2024

I think mainly testing. I also had in mind a CI (maybe not on GitHub) to monitor the precision after each PR. We can talk about it in #207.

@lgrcia
Copy link
Collaborator Author

lgrcia commented Sep 9, 2024

Before I merge, @dfm, do you think this is a meaningful thing to push to main? It's kind of a big addition only for testing so I'd love to have your feedback.

@lgrcia lgrcia changed the title feat: feat: add a multi-precision module for testing feat: add a multi-precision module for testing Sep 9, 2024
dfm
dfm approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@dfm dfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tiny comment inline, but this makes sense to me!

tests/precision/test_flux.py Outdated Show resolved Hide resolved
@lgrcia lgrcia added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit ae2f432 Sep 12, 2024
11 checks passed
@lgrcia lgrcia mentioned this pull request Oct 8, 2024
Closed
7 tasks
@lgrcia lgrcia mentioned this pull request Oct 17, 2024
Closed
soichiro-hattori pushed a commit to soichiro-hattori/jaxoplanet that referenced this pull request Oct 23, 2024
@lgrcia @pre-commit-ci @soichiro-hattori
feat: add a multi-precision module for testing (exoplanet-dev#210)
66601de 
* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 2, 2024
@soichiro-hattori @pre-commit-ci
@dependabot @lgrcia @dfm
Hotfix PR229 (#230)
efe4b4b 
* ipython version backend update

* add .vscode to gitignore file

* [pre-commit.ci] pre-commit autoupdate (#209)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.6.2...v0.6.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build(deps): bump pypa/gh-action-pypi-publish from 1.9.0 to 1.10.0 (#208)

Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#213)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.3 → v0.6.4](astral-sh/ruff-pre-commit@v0.6.3...v0.6.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Hotfix quickstart (#215)

* ipython version backend update

* add .vscode to gitignore file

* align occultation plot

* feat: add a multi-precision module for testing (#210)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: caching of multiprecision `sT` + static `Ylm.index` (#216)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* test: move multi-precision to general tests + supersede sympy symbolic (#218)

* test: move multi-precision to general tests + supersede sympy symbolic

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: move import in multiprecision tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test: add test R multi-precision

* fix: move mpmath import to skipped test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: missing import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: move import within skipped function

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#219)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.5](astral-sh/ruff-pre-commit@v0.6.4...v0.6.5)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#220)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.5 → v0.6.7](astral-sh/ruff-pre-commit@v0.6.5...v0.6.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: secondary/emission light curve of (limb-darkened) bodies (#223)

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build(deps): bump pypa/gh-action-pypi-publish from 1.10.0 to 1.10.2 (#222)

Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.10.0 to 1.10.2.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.10.0...v1.10.2)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: `None` values for angles (#225)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* feat: s2fft rotation matrices

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: add s2fft dep

* fix: skip long comparison to R symbolic (starry comparison is enough)

* fix: avoid nans and nan grads

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: solution cache

* fix: using single Ylm (ones) to test and plot precision

* fix: index as static method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

* fix: import issue coming from s2fft by using numpy<2.0

* feat: improved p integrals using symmetry and small order elements

* fix: sT key error in cached matrices

* fix: module level import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: apply symmetry to limb-dark P integral

* feat: pytest verbose flag

* test: check if test_compare_y_from_u is problematic

* test: test failure of other test on macos

* Don't run tests in parallel?

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

* fix: jax<=0.4.31

* fix: trying to fix macos-latest tests

* fix: trying to fix macos-latest tests

* fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: line too long and None cond (linter)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: no test skipped now that macos test bug solved

* fix: bad indent in docs

* fix: bad indent in docs

* fix: remove docstring from s2fft copied functions and turn to private

* feat: allow None values for angles related to rotations + fix phase of surface

* fix: conversion to starry test + docstrings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: angles property for Surface

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dan Foreman-Mackey <[email protected]>

* feat: rotation matrices using s2fft (#212)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* feat: s2fft rotation matrices

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: add s2fft dep

* fix: skip long comparison to R symbolic (starry comparison is enough)

* fix: avoid nans and nan grads

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: solution cache

* fix: using single Ylm (ones) to test and plot precision

* fix: index as static method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

* fix: import issue coming from s2fft by using numpy<2.0

* fix: sT key error in cached matrices

* fix: module level import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: pytest verbose flag

* test: check if test_compare_y_from_u is problematic

* test: test failure of other test on macos

* Don't run tests in parallel?

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

* fix: jax<=0.4.31

* fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: line too long and None cond (linter)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: no test skipped now that macos test bug solved

* fix: bad indent in docs

* fix: remove docstring from s2fft copied functions and turn to private

* fix: add note and license + jp.stack instead of loop

* fix: revert changes for testing

* fix: revert _generate_rotate_dls jnp.stack change

* feat: allow higher precision design matrices (for test only)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* fix: mpmath matrices caching for flux

* feat: improve _generate_rotate_dls

* test(fix): revert parallel tests

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dan Foreman-Mackey <[email protected]>

* feat: precision helper functions (#217)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* feat: s2fft rotation matrices

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: add s2fft dep

* fix: skip long comparison to R symbolic (starry comparison is enough)

* fix: avoid nans and nan grads

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: solution cache

* fix: using single Ylm (ones) to test and plot precision

* fix: index as static method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

* fix: import issue coming from s2fft by using numpy<2.0

* feat: improved p integrals using symmetry and small order elements

* fix: sT key error in cached matrices

* fix: module level import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: apply symmetry to limb-dark P integral

* feat: pytest verbose flag

* test: check if test_compare_y_from_u is problematic

* test: test failure of other test on macos

* Don't run tests in parallel?

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

* fix: jax<=0.4.31

* fix: trying to fix macos-latest tests

* fix: trying to fix macos-latest tests

* fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: line too long and None cond (linter)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: no test skipped now that macos test bug solved

* fix: bad indent in docs

* fix: bad indent in docs

* fix: remove docstring from s2fft copied functions and turn to private

* fix: add note and license + jp.stack instead of loop

* fix: revert changes for testing

* fix: revert _generate_rotate_dls jnp.stack change

* feat: allow higher precision design matrices (for test only)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* fix: optional mpmath import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* fix: mpmath matrices caching for flux

* fix: min low_order

* feat: a function to estimate the precision of different light curves, including limb darkened one

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: typo

* feat: improve _generate_rotate_dls

* fix: minimum low order

* fix: move mpmath import in test function

* fix: remove duplicate CACHED_MATRICES

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dan Foreman-Mackey <[email protected]>

* branch equinox converter to handle None

* tree.map -> tree_util.tree_map for backwards compatibility

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lionel Garcia <[email protected]>
Co-authored-by: Dan Foreman-Mackey <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 6, 2024
@soichiro-hattori @pre-commit-ci
@dependabot @lgrcia @dfm
Add multiwavelength transit fitting tutorial (#232)
194c9f6 
* ipython version backend update

* add .vscode to gitignore file

* [pre-commit.ci] pre-commit autoupdate (#209)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.6.2...v0.6.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build(deps): bump pypa/gh-action-pypi-publish from 1.9.0 to 1.10.0 (#208)

Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#213)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.3 → v0.6.4](astral-sh/ruff-pre-commit@v0.6.3...v0.6.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Hotfix quickstart (#215)

* ipython version backend update

* add .vscode to gitignore file

* align occultation plot

* feat: add a multi-precision module for testing (#210)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: caching of multiprecision `sT` + static `Ylm.index` (#216)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* test: move multi-precision to general tests + supersede sympy symbolic (#218)

* test: move multi-precision to general tests + supersede sympy symbolic

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: move import in multiprecision tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test: add test R multi-precision

* fix: move mpmath import to skipped test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: missing import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: move import within skipped function

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#219)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.5](astral-sh/ruff-pre-commit@v0.6.4...v0.6.5)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#220)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.5 → v0.6.7](astral-sh/ruff-pre-commit@v0.6.5...v0.6.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: secondary/emission light curve of (limb-darkened) bodies (#223)

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build(deps): bump pypa/gh-action-pypi-publish from 1.10.0 to 1.10.2 (#222)

Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.10.0 to 1.10.2.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.10.0...v1.10.2)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: `None` values for angles (#225)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* feat: s2fft rotation matrices

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: add s2fft dep

* fix: skip long comparison to R symbolic (starry comparison is enough)

* fix: avoid nans and nan grads

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: solution cache

* fix: using single Ylm (ones) to test and plot precision

* fix: index as static method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

* fix: import issue coming from s2fft by using numpy<2.0

* feat: improved p integrals using symmetry and small order elements

* fix: sT key error in cached matrices

* fix: module level import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: apply symmetry to limb-dark P integral

* feat: pytest verbose flag

* test: check if test_compare_y_from_u is problematic

* test: test failure of other test on macos

* Don't run tests in parallel?

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

* fix: jax<=0.4.31

* fix: trying to fix macos-latest tests

* fix: trying to fix macos-latest tests

* fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: line too long and None cond (linter)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: no test skipped now that macos test bug solved

* fix: bad indent in docs

* fix: bad indent in docs

* fix: remove docstring from s2fft copied functions and turn to private

* feat: allow None values for angles related to rotations + fix phase of surface

* fix: conversion to starry test + docstrings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: angles property for Surface

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dan Foreman-Mackey <[email protected]>

* feat: rotation matrices using s2fft (#212)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* feat: s2fft rotation matrices

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: add s2fft dep

* fix: skip long comparison to R symbolic (starry comparison is enough)

* fix: avoid nans and nan grads

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: solution cache

* fix: using single Ylm (ones) to test and plot precision

* fix: index as static method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

* fix: import issue coming from s2fft by using numpy<2.0

* fix: sT key error in cached matrices

* fix: module level import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: pytest verbose flag

* test: check if test_compare_y_from_u is problematic

* test: test failure of other test on macos

* Don't run tests in parallel?

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

* fix: jax<=0.4.31

* fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: line too long and None cond (linter)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: no test skipped now that macos test bug solved

* fix: bad indent in docs

* fix: remove docstring from s2fft copied functions and turn to private

* fix: add note and license + jp.stack instead of loop

* fix: revert changes for testing

* fix: revert _generate_rotate_dls jnp.stack change

* feat: allow higher precision design matrices (for test only)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* fix: mpmath matrices caching for flux

* feat: improve _generate_rotate_dls

* test(fix): revert parallel tests

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dan Foreman-Mackey <[email protected]>

* feat: precision helper functions (#217)

* feat: add a multi-precision module for testing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: linter errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: a closed form multi-precision A2 (way faster than inverting A2_inv)

* fix: mp diff

* feat: caching big matrices

* fix: avoid adding zero elements

* test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: top-level imports error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: cached matrices as kwarg

* feat: add gmpy2 for faster multi-precision arithmetic

* feat: s2fft rotation matrices

* fix: slightly change the caching per module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: cache added for R

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: add s2fft dep

* fix: skip long comparison to R symbolic (starry comparison is enough)

* fix: avoid nans and nan grads

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: caching or R

* fix: solution cache

* fix: using single Ylm (ones) to test and plot precision

* fix: index as static method

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: remove precision plots from tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: properly cache sT

* fix: index as static method

* fix: remove unused variable

* fix: redo last theta_z rotation

* fix: import issue coming from s2fft by using numpy<2.0

* feat: improved p integrals using symmetry and small order elements

* fix: sT key error in cached matrices

* fix: module level import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: apply symmetry to limb-dark P integral

* feat: pytest verbose flag

* test: check if test_compare_y_from_u is problematic

* test: test failure of other test on macos

* Don't run tests in parallel?

* feat: secondary/emission light curve of (limb-darkened) bodies

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: pin jax version

* fix: jax<=0.4.31

* fix: trying to fix macos-latest tests

* fix: trying to fix macos-latest tests

* fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: line too long and None cond (linter)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: no test skipped now that macos test bug solved

* fix: bad indent in docs

* fix: bad indent in docs

* fix: remove docstring from s2fft copied functions and turn to private

* fix: add note and license + jp.stack instead of loop

* fix: revert changes for testing

* fix: revert _generate_rotate_dls jnp.stack change

* feat: allow higher precision design matrices (for test only)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* fix: optional mpmath import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: optional mpmath import

* fix: mpmath matrices caching for flux

* fix: min low_order

* feat: a function to estimate the precision of different light curves, including limb darkened one

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: typo

* feat: improve _generate_rotate_dls

* fix: minimum low order

* fix: move mpmath import in test function

* fix: remove duplicate CACHED_MATRICES

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dan Foreman-Mackey <[email protected]>

* push to save

* adding multiwavelength transit fitting tutorial

* correct tutorial shorthand variable

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lionel Garcia <[email protected]>
Co-authored-by: Dan Foreman-Mackey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfm dfm dfm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgrcia @soichiro-hattori @dfm