Add missing validation against allow_grant_flow_for_client option
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to DeviceCodeRequest and DeviceAuthorizationRequest
irminsul
requested changes
Jul 3, 2023
Comment on lines
+127
to
+136
|
|
||
| [Unreleased]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v1.0.3...HEAD | ||
| [1.0.3]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v1.0.2...v1.0.3 | ||
| [1.0.2]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v1.0.1...v1.0.2 | ||
| [1.0.1]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v1.0.0...v1.0.1 | ||
| [1.0.0]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v0.2.1...v1.0.0 | ||
| [0.2.1]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v0.2.0...v0.2.1 | ||
| [0.2.0]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v0.1.1...v0.2.0 | ||
| [0.1.1]: https://github.com/exop-group/doorkeeper-device_authorization_grant/compare/v0.1.0...v0.1.1 | ||
| [0.1.0]: https://github.com/exop-group/doorkeeper-device_authorization_grant/releases/tag/v0.1.0 |
There was a problem hiding this comment.
Where's all that suddenly coming from?
There was a problem hiding this comment.
Oh I realized that we used "[links]" for version's heading, but they were not pointing to anything. That's a typical destination.
About this change, I admit I've been a little insolent and didn't bother to comment in the commit message... 😇
| @@ -13,6 +13,7 @@ class DeviceAuthorizationRequest < Doorkeeper::OAuth::BaseRequest | |||
| attr_accessor :host_name | |||
|
|
|||
| validate :client, error: :invalid_client | |||
| validate :client_supports_grant_flow, error: :unauthorized_client | |||
There was a problem hiding this comment.
I noticed that other Doorkeeper grants also validate the requested scopes. I suppose we should do that too, even if our own applications don't use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14