Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Knapcask exercise #1199

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Conversation

tofische
Copy link
Contributor

Added a new Haskell practice exercise Knapsack based on the available problem specification.

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 29, 2024
config.json Outdated
Comment on lines 1123 to 1134
{
"slug": "rational-numbers",
"name": "Rational Numbers",
"uuid": "b4426fe9-2e49-48c5-9dea-c86032009687",
"practices": [],
"prerequisites": [],
"difficulty": 3,
"topics": [
"define_type",
"math",
"number_theory"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be unrelated

@@ -0,0 +1,21 @@
{
"authors": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add your github username to this array?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an unrelated change. Could you remove all unrelated changes from the PR?

@ErikSchierboom ErikSchierboom requested a review from a team January 31, 2024 13:11
ErikSchierboom and others added 7 commits January 31, 2024 20:15
* Sync the `leap` exercise's docs with the latest data.

* Sync the `leap` exercise's metadata with the latest data.
* Sync the `reverse-string` exercise's docs with the latest data.

* Sync the `reverse-string` exercise's metadata with the latest data.
* Added Rational Numbers exercise

* Incorporated review comments from exercism#1193
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ErikSchierboom ErikSchierboom merged commit 88aa9dc into exercism:main Feb 1, 2024
3 of 4 checks passed
@tofische tofische deleted the knapsack-exercise branch February 1, 2024 08:36
@MatthijsBlom
Copy link
Contributor

Sorry for being late.

I would have preferred data Item = Item { weight :: Int, value :: Int }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants