-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Knapcask exercise #1199
Added Knapcask exercise #1199
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
config.json
Outdated
{ | ||
"slug": "rational-numbers", | ||
"name": "Rational Numbers", | ||
"uuid": "b4426fe9-2e49-48c5-9dea-c86032009687", | ||
"practices": [], | ||
"prerequisites": [], | ||
"difficulty": 3, | ||
"topics": [ | ||
"define_type", | ||
"math", | ||
"number_theory" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unrelated
@@ -0,0 +1,21 @@ | |||
{ | |||
"authors": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add your github username to this array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an unrelated change. Could you remove all unrelated changes from the PR?
c5a298d
to
b020272
Compare
* Sync the `leap` exercise's docs with the latest data. * Sync the `leap` exercise's metadata with the latest data.
* Sync the `reverse-string` exercise's docs with the latest data. * Sync the `reverse-string` exercise's metadata with the latest data.
* Added Rational Numbers exercise * Incorporated review comments from exercism#1193
This reverts commit 6e6e5c1.
This reverts commit 9dfbea9.
This reverts commit fe898ba.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sorry for being late. I would have preferred |
Added a new Haskell practice exercise Knapsack based on the available problem specification.