-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reverse-string exercise #1191
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Started a new topic in the forums for this: https://forum.exercism.org/t/added-reverse-string-exercise-to-haskell-track/9213 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdimitroulas Once the review suggestions are addressed, I'll merge this
Co-authored-by: Matthijs <[email protected]>
@MatthijsBlom thanks for the review! @ErikSchierboom did you see my comment on the forums about the example solution?
Curious to know how you folks feel about this? |
The goal of the example solution is just to prove that there is a solution that passed the tests. In other words: to verify that students will be able to solve the exercise. So a simple example is perfectly fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final, tiny nit
As part of preparation for 48in24, I saw in the Exercism forums that the
reverse-string
exercise will be coming up on the 23rd of January and the Haskell track did not have this exercise implemented.This PR implements the exercise. Apologies if I have missed anything, this is my first time contributing to an Exercism language track.