Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge CI workflows on PR and on commit to main #1345

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Merge CI workflows on PR and on commit to main #1345

merged 1 commit into from
Aug 2, 2023

Conversation

angelikatyborska
Copy link
Contributor

Resolves #1344

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

neenjaw
neenjaw approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, appreciate the simplification here. Curious, was there a bug(s) that slipped through from this not being run on every commit?

@angelikatyborska
Copy link
Contributor Author

No, bugs didn't slip in as far as I know. It was just annoying to have to duplicate changes every time a CI flow needed something new 🙂

@angelikatyborska angelikatyborska merged commit fc0f621 into main Aug 2, 2023
11 checks passed
@angelikatyborska angelikatyborska deleted the single-ci-workflow branch August 2, 2023 23:13
@neenjaw
Copy link
Contributor

neenjaw commented Aug 3, 2023

Totally agree with that sentiment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neenjaw neenjaw neenjaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does this repository have two identical github workflows?
2 participants
@angelikatyborska @neenjaw