Skip to content

Commit

Permalink
Add PK to configuration (#209)
Browse files Browse the repository at this point in the history
* Have to specify revision explicitly

* Revert the change, adding the comment

* Revert everything

* Add project keeper plugin

* Fix project-keeper

* Silence PK warnings

* Update description

* Update doc/changes/changes_2.1.4.md

Co-authored-by: Sebastian Bär <[email protected]>

* Update doc/changes/changes_2.1.4.md

Co-authored-by: Sebastian Bär <[email protected]>

---------

Co-authored-by: Christoph Pirkl <[email protected]>
Co-authored-by: Sebastian Bär <[email protected]>
  • Loading branch information
3 people authored Oct 26, 2023
1 parent 07bb831 commit f1c6c3f
Show file tree
Hide file tree
Showing 8 changed files with 203 additions and 183 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pk-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
key: ${{ runner.os }}-sonar
restore-keys: ${{ runner.os }}-sonar
- name: Run Project Keeper Separately
run: mvn --batch-mode -DtrimStackTrace=false com.exasol:project-keeper-maven-plugin:2.9.12:verify --projects .
run: mvn --batch-mode -DtrimStackTrace=false com.exasol:project-keeper-maven-plugin:verify --projects .
1 change: 1 addition & 0 deletions .project-keeper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ excludes:
- "E-PK-CORE-18: Outdated content: '.github/workflows/release_droid_upload_github_release_assets.yml'"
- "E-PK-CORE-18: Outdated content: '.github/workflows/release_droid_release_on_maven_central.yml'"
- "E-PK-CORE-18: Outdated content: '.settings/org.eclipse.jdt.core.prefs'"
- regex: ".*W-PK-CORE-151: Pom file '.*/pom.xml' contains no reference to project-keeper-maven-plugin."
- regex: "(?s)E-PK-CORE-18: Outdated content: 'exasol-(jdbc|s3)/pk_generated_parent.pom'"
- regex: "(?s)E-PK-CORE-104: Invalid pom file 'exasol-(jdbc|s3)/pom.xml': Invalid /project/parent/artifactId.*"
- regex: "(?s)E-PK-CORE-118: Invalid pom file 'exasol-(jdbc|s3)/pom.xml': Invalid /project/parent/version.*"
Expand Down
333 changes: 158 additions & 175 deletions dependencies.md

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions doc/changes/changelog.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions doc/changes/changes_2.1.4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Spark Connector 2.1.4, released 2023-??-??

Code name:

## Summary

Project keeper added to Maven configuration.

## Features

* #211: Brought PK plugin back to the Maven config

## Dependency Updates

### Spark Exasol Connector Parent POM

#### Plugin Dependency Updates

* Updated `com.exasol:error-code-crawler-maven-plugin:1.3.0` to `1.3.1`
* Updated `org.apache.maven.plugins:maven-enforcer-plugin:3.4.0` to `3.4.1`
* Updated `org.codehaus.mojo:versions-maven-plugin:2.16.0` to `2.16.1`
* Updated `org.jacoco:jacoco-maven-plugin:0.8.10` to `0.8.11`
* Updated `org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184` to `3.10.0.2594`
12 changes: 6 additions & 6 deletions parent-pom/pk_generated_parent.pom

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion parent-pom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<relativePath>pk_generated_parent.pom</relativePath>
</parent>
<properties>
<revision>2.1.3</revision>
<revision>2.1.4</revision>
<java.version>8</java.version>
<log4j.version>2.20.0</log4j.version>
<junit.version>5.10.0</junit.version>
Expand Down
12 changes: 12 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@
<skip>true</skip>
</configuration>
</plugin>
<plugin>
<groupId>com.exasol</groupId>
<artifactId>project-keeper-maven-plugin</artifactId>
<version>2.9.14</version>
<executions>
<execution>
<goals>
<goal>verify</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
<profiles>
Expand Down

0 comments on commit f1c6c3f

Please sign in to comment.