#38: Add extension #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
requested changes
Nov 10, 2023
| @@ -0,0 +1,50 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I feel some headaches about this shell script.
- It introduces another script language on top of Java, golang, and typescript
- It introduces additional logic on top of the build systems maven, go and NPM.
- Potentially has limited portability, e.g. on Windows OS or other linux distros.
- It could cause some code duplication as the script probably it will look similar for other VS.
I am fine to leave it as it is for the current PR, but I'd love if we could find a better solution in general.
src/test/java/com/exasol/adapter/dialects/oracle/OracleContainerDBA.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Kuhnke <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
ckunki
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38