Add v8 to ci #37
Merged
Add v8 to ci #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Kudos, SonarCloud Quality Gate passed!
|
ckunki
requested changes
Nov 10, 2023
src/test/java/com/exasol/adapter/dialects/oracle/OracleVirtualSchemaIntegrationTestSetup.java
Show resolved
Hide resolved
src/test/java/com/exasol/adapter/dialects/oracle/OracleVirtualSchemaIntegrationTestSetup.java
Show resolved
Hide resolved
| /** | ||
| * This JUnit extension closes resources in static fields that are annotated with {@code @CloseAfterAll}. You can use it | ||
| * by annotating your class with {@code @ExtendWith({ CloseAfterAllExtension.class })}. | ||
| * by annotating your class with {@code @ExtendWith({ CloseAfterAllExtension.class })}. |
There was a problem hiding this comment.
Wow number two: This also sounds helpful fixing warnings about potentially unclosed resources, right?
ckunki
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #33