Bug/fix download url for slc file #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicoretti
reviewed
Nov 4, 2024
Comment on lines
28
to
32
| - name: PyPi Release | ||
| env: | ||
| POETRY_HTTP_BASIC_PYPI_USERNAME: "__token__" | ||
| POETRY_HTTP_BASIC_PYPI_PASSWORD: "${{ secrets.PYPI_TOKEN }}" | ||
| run: poetry publish |
There was a problem hiding this comment.
You are right, additionally (as part of the clean-up after the release) I moved the pypi release back to the old position in the workflow, which is before the GitHub release.
I hope, this is OK for you?
There was a problem hiding this comment.
But I am not ok with it, because a PyPi release doesn't make sense, if we couldn't upload the SLC
Nicoretti
previously approved these changes
Nov 4, 2024
tkilias
requested changes
Nov 4, 2024
Reverted. Please see latest push. |
tkilias
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206