#190 enabled to generate a dynamic module for custom udf #202
Conversation
|
|
||
| AAF contains some generated files that are committed to git, including: | ||
| * The amalgated Lua script [create_query_loop.sql](https://github.com/exasol/advanced-analytics-framework/blob/main/exasol_advanced_analytics_framework/resources/outputs/create_query_loop.sql) | ||
| * The examples in the user guide |
There was a problem hiding this comment.
Thanks - I removed the main instructions but forgot to update the bullet list.
See next push fixing the bullet list, too.
| "parameter": "bla-bla", | ||
| "udf": { | ||
| "schema": "EXAMPLE_SCHEMA", | ||
| "name": "MY_QUERY_HANDLER_UDF" |
There was a problem hiding this comment.
if we already run with the word example, should we use it everywhere (half a joke)
There was a problem hiding this comment.
Actually, during my experiments, I switched from MY_SCHEMA to MY_EXAMPLE to avoid false positive test results due to my test database being already partially initialized.
Should I replace the name MY_QUERY_HANDLER_UDF by EXAMPLE_QUERY_HANDLER_UDF?
doc/user_guide/user_guide.md
Outdated
| --language-alias "$LANGUAGE_ALIAS" | ||
| ``` | ||
|
|
||
| The name of the database schema must match the schema when executing the script. |
| code to add classes and functions to the module. | ||
| """ | ||
| mod = sys.modules.get(name) | ||
| if mod is None: |
There was a problem hiding this comment.
I think, we actually should fail, when the module exists
Co-authored-by: Torsten Kilias <[email protected]>
doc/user_guide/user_guide.md
Outdated
| from exasol_advanced_analytics_framework.udf_framework.query_handler_runner_udf \ | ||
| import QueryHandlerRunnerUDF | ||
| ```shell | ||
| ALTER SESSION SET SCRIPT_LANGUAGES='R=builtin_r JAVA=builtin_java PYTHON3=builtin_python3 PYTHON3_AAF=localzmq+protobuf:///bfsdefault/default/temp/exasol_advanced_analytics_framework_container_release?lang=python#/buckets/bfsdefault/default/temp/exasol_advanced_analytics_framework_container_release/exaudf/exaudfclient_py3'; |
There was a problem hiding this comment.
I applied your proposal, @tkilias.
How about the assumptions?
Maybe we first try to identify all assumptions?
Thinking about it: maybe we can omit the ALTER SESSION statement, as all this is already done by the AAF deploy command?
There was a problem hiding this comment.
See next push without ALTER SESSION command.
- Renamed MY_QUERY_HANDLER_UDF to EXAMPLE_QUERY_HANDLER_UDF - Renamed BFS_CON to EXAMPLE_BFS_CON - Removed section "Activating the AAF SLC by Setting a Language Alias"
ckunki
deleted the
refactoring/#190-Enabled_to_generate_a_dynamic_module_for_custom_UDF
branch
Closes #190