Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssumeRoleWithWebIdentity #12

Merged

Conversation

rafaelgaspar
Copy link
Contributor

This adds support for AssumeRoleWithWebIdentity according to AWS Documentation at: https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRoleWithWebIdentity.html

@rafaelgaspar rafaelgaspar force-pushed the add-assume-role-with-web-identity branch 2 times, most recently from f8e37ce to bec98da Compare October 16, 2019 14:41
@rafaelgaspar rafaelgaspar force-pushed the add-assume-role-with-web-identity branch from bec98da to b2ffac6 Compare October 16, 2019 14:59
@tecnobrat
Copy link

I'm unsure what the merging policy is here, but looking at the code and tests, this looks really good to me.

We're looking for this feature to handle EKS roles.

@maur1th
Copy link

maur1th commented Dec 2, 2019

We need this as well. What is blocking this PR?

@benwilson512
Copy link
Contributor

What is blocking this PR?

#1

@rafaelgaspar
Copy link
Contributor Author

Just as an update, I'm waiting for reviews on this and some confirmation that the project is not dead, since it's been more than a month now.

After that it would still be missing an AuthCache Adapter to be able to use it as an authentication mechanism for ex_aws, that I will work on as soon I get a confirmation that this project is not dead.

@benwilson512
Copy link
Contributor

@rafaelgaspar as the original project author, I'm trying to say that this project needs a maintainer. ExAws has become federated since it was impossible for one person to handle all of the libraries. If you'd like to be the maintainer we can discuss that.

@dcaixinha
Copy link

Hey, I'm currently needing this as well at work. Given there are people volunteering to maintain on #1, can this get unblocked @benwilson512? 🙏 after this gets merged we can open a PR to add the new auth adapter 🙌

@benwilson512 benwilson512 merged commit 9ac78a1 into ex-aws:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants