Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message when contract imports unimplemented host functions #538

Open
cdetrio opened this issue May 4, 2019 · 3 comments
Open

Comments

@cdetrio
Copy link
Contributor

cdetrio commented May 4, 2019

When trying to import an unimplemented host function using wabt, the only error message is:

geth_evmc_test.go:143: evmc: contract validation failure
@axic
Copy link
Member

axic commented May 4, 2019

Checked wabt and I'm not sure it is easy to do this :(

However we could extend chisel to display unknown/invalid symbols.

@aarlt
Copy link
Contributor

aarlt commented Jun 9, 2019

hmm.. i only looked briefly in the evmc interface, so probably im wrong.. but is there any concept of returning "error messages" (in contrast to simple return codes) back from an evmc implementation? i was also not able to find geth_evmc_test.go, so i dont know the full context of this issue..

@axic
Copy link
Member

axic commented Nov 6, 2019

but is there any concept of returning "error messages" (in contrast to simple return codes) back from an evmc implementation?

Yes, but problem we had here is getting specific messages from wabt in the first place.

Hopefully #540 improved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants