Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge common code from verifyContract and execute to a helper in wabt #491

Open
axic opened this issue Feb 8, 2019 · 2 comments
Open

Merge common code from verifyContract and execute to a helper in wabt #491

axic opened this issue Feb 8, 2019 · 2 comments

Comments

@axic
Copy link
Member

axic commented Feb 8, 2019

No description provided.

@aarlt
Copy link
Contributor

aarlt commented Jun 9, 2019

is this about implementing parts of verifyContract and execute as generic as possible, so that those parts can be reused within different WasmEngine's? Why should this be moved to a helper specifically in wabt?

@axic axic removed the help wanted label Jun 19, 2019
@axic
Copy link
Member Author

axic commented Jun 19, 2019

Binaryen/wavm have a much slimmer verifyContract, but in wabt it is basically a duplicate of execute, hence the goal would be to improve the wabt code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axic @aarlt