Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use snake cases with underscore test name convention in Arch tests #69

Merged
merged 1 commit into from
Dec 30, 2023
Merged

style: use snake cases with underscore test name convention in Arch tests #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/ContractsArchitectureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

using Common;

public class ContractsArchitectureTests
public sealed class ContractsArchitectureTests
{
private readonly Assembly _solution = typeof(Program).Assembly;

[Theory]
[InlineData(Modules.Passes)]
[InlineData(Modules.Offers)]
[InlineData(Modules.Reports)]
public void ContractsShouldNotHaveDependencyOnModule(string moduleName)
internal void Contracts_should_not_have_dependency_on_module(string moduleName)
{
// Arrange
var contractsModule = Types.InAssembly(_solution)
Expand Down
2 changes: 1 addition & 1 deletion ...nitial-architecture/Src/Fitnet.ArchitectureTests/Conventions/EndpointsConventionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public sealed class EndpointsConventionsTests
private const string Endpoint = "Endpoint";

[Fact]
internal void ShouldBeStatic()
internal void Should_be_static()
{
// Arrange
var rules = Solution.Types.That()
Expand Down
2 changes: 1 addition & 1 deletion ...itial-architecture/Src/Fitnet.ArchitectureTests/Conventions/InterfacesConventionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
public sealed class InterfacesConventionsTests
{
[Fact]
internal void ShouldStartWithI()
internal void Should_start_with_I()
{
// Arrange
var rules = Solution.Types.That()
Expand Down
4 changes: 2 additions & 2 deletions Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/OffersArchitectureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

using Common;

public class OffersArchitectureTests
public sealed class OffersArchitectureTests
{
private const string Event = "Event";

[Theory]
[InlineData(Modules.Contracts)]
[InlineData(Modules.Reports)]
public void OffersShouldNotHaveDependencyOnModule(string moduleName)
internal void Offers_should_not_have_dependency_on_module(string moduleName)
{
// Arrange
var offersModule = Solution.Types
Expand Down
6 changes: 3 additions & 3 deletions Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/PassesArchitectureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ namespace EvolutionaryArchitecture.Fitnet.ArchitectureTests;

using Common;

public class PassesArchitectureTests
public sealed class PassesArchitectureTests
{
private const string Event = "Event";

[Theory]
[InlineData(Modules.Offers)]
[InlineData(Modules.Reports)]
public void PassesShouldNotHaveDependencyOnModule(string moduleName)
internal void Passes_should_not_have_dependency_on_module(string moduleName)
{
// Arrange
var passesModule = Solution.Types
Expand All @@ -32,7 +32,7 @@ public void PassesShouldNotHaveDependencyOnModule(string moduleName)
}

[Fact]
public void PassesShouldCommunicateWithContractViaEvents()
internal void PassesShouldCommunicateWithContractViaEvents()
{
// Arrange
var passesModule = Solution.Types
Expand Down
4 changes: 2 additions & 2 deletions Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/ReportsArchitectureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ namespace EvolutionaryArchitecture.Fitnet.ArchitectureTests;

using Common;

public class ReportsArchitectureTests
public sealed class ReportsArchitectureTests
{
[Theory]
[InlineData(Modules.Contracts)]
[InlineData(Modules.Passes)]
[InlineData(Modules.Offers)]
public void ReportsShouldNotHaveDependencyOnModule(string moduleName)
internal void Reports_should_not_have_dependency_on_module(string moduleName)
{
// Arrange
var reportsModule = Solution.Types
Expand Down