-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add architecture test which ensure that others modules do not use contract internals #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilbaczek
changed the title
feat: add contracts architecture test
feat: add architecture test which ensure that others modules do not use contract internals
Dec 20, 2023
meaboutsoftware
requested changes
Dec 21, 2023
...tial-architecture/Src/Fitnet.ArchitectureTests/Contracts/ContractsModuleArchitectureTests.cs
Outdated
Show resolved
Hide resolved
...tial-architecture/Src/Fitnet.ArchitectureTests/Contracts/ContractsModuleArchitectureTests.cs
Outdated
Show resolved
Hide resolved
...tial-architecture/Src/Fitnet.ArchitectureTests/Contracts/ContractsModuleArchitectureTests.cs
Outdated
Show resolved
Hide resolved
...tial-architecture/Src/Fitnet.ArchitectureTests/Contracts/ContractsModuleArchitectureTests.cs
Outdated
Show resolved
Hide resolved
...tial-architecture/Src/Fitnet.ArchitectureTests/Contracts/ContractsModuleArchitectureTests.cs
Outdated
Show resolved
Hide resolved
kamilbaczek
force-pushed
the
feature/architecture_tests_chapter_1
branch
from
December 21, 2023 19:49
34237a0
to
b04fffc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 96.80% 96.81%
=======================================
Files 61 61
Lines 532 533 +1
Branches 9 9
=======================================
+ Hits 515 516 +1
Misses 14 14
Partials 3 3 ☔ View full report in Codecov by Sentry. |
kamilbaczek
force-pushed
the
feature/architecture_tests_chapter_1
branch
from
December 26, 2023 15:07
87a223e
to
49f661c
Compare
kamilbaczek
force-pushed
the
feature/architecture_tests_chapter_1
branch
from
December 28, 2023 18:01
9ce808d
to
6df83e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.