✨ replace the feature flag manager-based module availability checker with a configuration-based module availability checker #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilbaczek
changed the title
meaboutsoftware
requested changes
May 26, 2024
Chapter-2-modules-separation/Src/Common/Fitnet.Common.Core/Fitnet.Common.Core.csproj
Outdated
Show resolved
Hide resolved
Chapter-2-modules-separation/Src/Common/Fitnet.Common.Api/Fitnet.Common.Api.csproj
Outdated
Show resolved
Hide resolved
...ules-separation/Src/Common/Fitnet.Common.Infrastructure/Modules/ModuleAvailabilityChecker.cs
Outdated
Show resolved
Hide resolved
....Common.Infrastructure.IntegrationTests/Fitnet.Common.Infrastructure.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
...separation/Src/Common/Tests/Fitnet.Common.Core.UnitTests/Fitnet.Common.Core.UnitTests.csproj
Outdated
Show resolved
Hide resolved
...ter-2-modules-separation/Src/Passes/Fitnet.Passes.DataAccess/Fitnet.Passes.DataAccess.csproj
Outdated
Show resolved
Hide resolved
...separation/Src/Passes/Fitnet.Passes.IntegrationEvents/Fitnet.Passes.IntegrationEvents.csproj
Outdated
Show resolved
Hide resolved
...ration/Src/Passes/Tests/Fitnet.Passes.IntegrationTests/Fitnet.Passes.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
Chapter-2-modules-separation/Src/Reports/Fitnet.Reports/Fitnet.Reports.csproj
Outdated
Show resolved
Hide resolved
...ion/Src/Reports/Tests/Fitnet.Reports.IntegrationTests/Fitnet.Reports.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
meaboutsoftware
approved these changes
May 27, 2024
kamilbaczek
force-pushed
the
feature/replace_feature_flag_based_module_loader_to_configuration_based_module_loader
branch
from
07f1b1c to
683080c
Compare
kamilbaczek
deleted the
feature/replace_feature_flag_based_module_loader_to_configuration_based_module_loader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
Replace the feature flag manager-based module availability checker with a configuration-based module availability checker. ⚙️
This change shifts the mechanism for checking module availability from using feature flags to using configuration settings, simplifying the process and improving maintainability. 📊
📦 PR Includes
💡 Additional Notes
No additional notes