Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date time handling in chapter 1 #108

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

meaboutsoftware
Copy link
Collaborator

This PR includes changes related to switching custom system clock abstraction (built on .NET 7) with TimeProvider (built-in .NET 8)

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.49%. Comparing base (7695cc7) to head (501c0a7).
Report is 16 commits behind head on main.

Files Patch % Lines
...ntracts/SignContract/Events/ContractSignedEvent.cs 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   96.81%   96.49%   -0.32%     
==========================================
  Files          61       61              
  Lines         533      542       +9     
  Branches        9        9              
==========================================
+ Hits          516      523       +7     
- Misses         14       16       +2     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meaboutsoftware meaboutsoftware marked this pull request as ready for review April 2, 2024 13:31
@meaboutsoftware meaboutsoftware force-pushed the fix/datetime_handling_in_chapter_1 branch from 8eb17c2 to 38aa8e3 Compare April 2, 2024 16:22
@meaboutsoftware meaboutsoftware merged commit 24f85a7 into main Apr 2, 2024
2 checks passed
@meaboutsoftware meaboutsoftware deleted the fix/datetime_handling_in_chapter_1 branch April 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants