fix: operating on contract id instead of binding contract id

evolutionary-architecture · Apr 5, 2024 · e89d7a6 · e89d7a6
1 parent 9587955
commit e89d7a6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/....Contracts.Application/TerminateBindingContract/TerminateBindingContractCommandHandler.cs b/....Contracts.Application/TerminateBindingContract/TerminateBindingContractCommandHandler.cs
@@ -10,7 +10,7 @@ internal sealed class TerminateBindingContractCommandHandler(
 {
     public async Task Handle(TerminateBindingContractCommand command, CancellationToken cancellationToken)
     {
-        var contract = await bindingContractsRepository.GetByIdAsync(command.Id, cancellationToken) ??
+        var contract = await bindingContractsRepository.GetByContractIdAsync(command.Id, cancellationToken) ??
                        throw new ResourceNotFoundException(command.Id);
         var terminatedAt = timeProvider.GetUtcNow();
         contract.Terminate(terminatedAt);

diff --git a/...n-driven-design/Fitnet.Contracts/Src/Fitnet.Contracts.Core/IBindingContractsRepository.cs b/...n-driven-design/Fitnet.Contracts/Src/Fitnet.Contracts.Core/IBindingContractsRepository.cs
@@ -2,7 +2,7 @@
 
 public interface IBindingContractsRepository
 {
-    Task<BindingContract?> GetByIdAsync(Guid id, CancellationToken cancellationToken = default);
+    Task<BindingContract?> GetByContractIdAsync(Guid contractId, CancellationToken cancellationToken = default);
     Task AddAsync(BindingContract bindingContract, CancellationToken cancellationToken = default);
     Task CommitAsync(CancellationToken cancellationToken = default);
 }
diff --git a/...s/Src/Fitnet.Contracts.Infrastructure/Database/Repositories/BindingContractsRepository.cs b/...s/Src/Fitnet.Contracts.Infrastructure/Database/Repositories/BindingContractsRepository.cs
@@ -1,11 +1,14 @@
 namespace EvolutionaryArchitecture.Fitnet.Contracts.Infrastructure.Database.Repositories;
 
 using Core;
+using Microsoft.EntityFrameworkCore;
 
 internal sealed class BindingContractsRepository(ContractsPersistence persistence) : IBindingContractsRepository
 {
-    public async Task<BindingContract?> GetByIdAsync(Guid id, CancellationToken cancellationToken = default) =>
-        await persistence.BindingContracts.FindAsync([new ContractId(id)], cancellationToken);
+    public async Task<BindingContract?> GetByContractIdAsync(Guid contractId,
+        CancellationToken cancellationToken = default) =>
+        await persistence.BindingContracts.Where(bc => bc.ContractId == new ContractId(contractId))
+            .SingleOrDefaultAsync(cancellationToken: cancellationToken);
 
     public async Task AddAsync(BindingContract bindingContract, CancellationToken cancellationToken = default)
     {